nordic: use portable IRQ pending API in drivers/socs - #117388
Open
nashif wants to merge 7 commits into
Open
Conversation
zephyrbot
added
area: Architectures
area: ARM
zephyrbot
requested review from
aescolar,
anangl,
andyross,
bjarki-andreasen,
carlescufi,
ceolin,
cvinayak,
dcpleung,
erbr-ot,
ithinuel,
jaz1-nordic,
jfischer-no,
josuah,
kartben and
kl-cruz
August 26, 2026 00:24
This test turns on ARM_CUSTOM_INTERRUPT_CONTROLLER on every Cortex-M platform, which routes the architecture IRQ operations to z_soc_irq_*() hooks that the test implements on top of the NVIC. It provides the enable, disable, is_enabled, priority, EOI and get_active hooks but not the pending-state ones, and since ARCH_HAS_IRQ_PENDING_OPS is only selected for a plain NVIC, k_irq_*_pending() disappears in this configuration. Drivers that are always part of the image -- system timers and console UARTs -- and that use k_irq_clear_pending() therefore fail to build here, for example mchp_xec_rtos_timer.c on mec15xxevb_assy6853: error: implicit declaration of function 'k_irq_clear_pending' Select ARCH_HAS_IRQ_PENDING_OPS from the test's Kconfig and add NVIC backed z_soc_irq_clear_pending(), z_soc_irq_set_pending() and z_soc_irq_is_pending(), the same way the test already wraps the NVIC for the other hooks. This is exactly what an SoC with a custom controller that can report and clear pending state is expected to do. Built with tests/arch/arm/arm_custom_interrupt on mec15xxevb_assy6853/mec1501_hsz, nrf52840dk/nrf52840, da1469x_dk_pro, apollo3_evb, rts5912_evb and mps2/an385 together with the k_irq_* driver conversions. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
cvinayak
requested changes
Aug 26, 2026
Comment on lines
+66
to
+67
| #include <zephyr/irq.h> | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| #include <zephyr/irq.h> |
aescolar
previously requested changes
Aug 26, 2026
Member
There was a problem hiding this comment.
There is a bug on posix_sw_is_pending_IRQ() (pending != pending & not masked)
The naming of the new functions is off.
The native sim irq handler is not limited to 64 interrupts, better to not limit it now.
This would break out of tree boards, but we don't have to.
Why not add ARCH_HAS_IRQ_GET_ACTIVE also (the underlying API was there already)
Circumstantial: The posix arch and native sim are not nordic boards (even if I work today for nordic), so this should be a separate PR.
Instead of iterating here clarifying the issues, I just queued another version without all these in:
Member
Author
right, I actually had another branch preped for posix_arch, but missed pushing it on its own :| topic/irq-pending/arch-posix, added here because I hot some depenendy with nrf_bsim I guess. |
Replace direct NVIC_SetPendingIRQ()/NVIC_ClearPendingIRQ() calls with k_irq_set_pending()/k_irq_clear_pending(). The portable API is backed by the NVIC on the Nordic hardware targets and by the POSIX-arch board interface on the simulated bsim targets, so the CMSIS emulation layer is no longer involved. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Replace direct NVIC_SetPendingIRQ()/NVIC_ClearPendingIRQ() calls with k_irq_set_pending()/k_irq_clear_pending(). The portable API is backed by the NVIC on the Nordic hardware targets and by the POSIX-arch board interface on the simulated bsim targets, so the CMSIS emulation layer is no longer involved. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Replace direct NVIC_SetPendingIRQ()/NVIC_ClearPendingIRQ() calls with k_irq_set_pending()/k_irq_clear_pending(). The portable API is backed by the NVIC on the Nordic hardware targets and by the POSIX-arch board interface on the simulated bsim targets, so the CMSIS emulation layer is no longer involved. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Replace direct NVIC_SetPendingIRQ()/NVIC_ClearPendingIRQ() calls with k_irq_set_pending()/k_irq_clear_pending(). The portable API is backed by the NVIC on the Nordic hardware targets and by the POSIX-arch board interface on the simulated bsim targets, so the CMSIS emulation layer is no longer involved. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Replace direct NVIC_SetPendingIRQ()/NVIC_ClearPendingIRQ() calls with k_irq_set_pending()/k_irq_clear_pending(). The portable API is backed by the NVIC on the Nordic hardware targets and by the POSIX-arch board interface on the simulated bsim targets, so the CMSIS emulation layer is no longer involved. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
Replace direct NVIC_SetPendingIRQ()/NVIC_ClearPendingIRQ() calls with k_irq_set_pending()/k_irq_clear_pending(). The portable API is backed by the NVIC on the Nordic hardware targets and by the POSIX-arch board interface on the simulated bsim targets, so the CMSIS emulation layer is no longer involved. Assisted-by: Claude:claude-opus-5 Signed-off-by: Anas Nashif <anas.nashif@intel.com>
nashif
force-pushed
the
topic/irq-pending/nordic
branch
from
August 26, 2026 10:53
d0340d5 to
fbc5566
Compare
zephyrbot
added
area: Tests
zephyrbot
requested review from
MarkWangChinese,
MaureenHelm,
Thalley,
lstnl,
magp-nordic,
mstasiaknordic,
nika-nordic,
nordic-krch,
nordicjm,
npitre,
roma-jam,
stephanosio,
sylvioalves,
teburd and
thoh-ot
August 26, 2026 10:56
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edit by @aescolar
Related